TST (string dtype): clean-up interpolate tests #60653
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
added
Testing
WillAyd
approved these changes
Jan 3, 2025
|
Milestone should be 2.3 right? |
rhshadrach
reviewed
Jan 3, 2025
Comment on lines
-104
to
-112
| if not using_infer_string: | ||
| with pytest.raises(TypeError, match=msg): | ||
| df.set_index("C").interpolate() | ||
| else: | ||
| result = df.set_index("C").interpolate() | ||
| expected = df.set_index("C") | ||
| expected.loc[3, "A"] = 2.66667 | ||
| expected.loc[5, "B"] = 9 | ||
| tm.assert_frame_equal(result, expected) |
There was a problem hiding this comment.
Previously this test was showing an API discrepancy between object vs string dtypes. Maybe just open an issue to track?
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small follow-up on #60637: move the code checking for the error for non-numeric data to a separate test, so we can actually still test the "basic" behaviour properly in the case there are only numeric columns. And remove the xfail for the non-range index case.